On Tuesday 15 August 2006 17:38, Laurent Riffard wrote:

Le 15.08.2006 12:10, Rafael J. Wysocki a écrit :

quoted

On Tuesday 15 August 2006 01:01, Laurent Riffard wrote:

quoted

Le 14.08.2006 23:25, Rafael J. Wysocki a écrit :

quoted

On Monday 14 August 2006 22:06, Laurent Riffard wrote:

quoted

Le 14.08.2006 19:47, Laurent Riffard a écrit :

quoted

Le 14.08.2006 18:50, Andrew Morton a écrit :

quoted

On Mon, 14 Aug 2006 16:38:47 +0200
Laurent Riffard [off-list ref] wrote:

]--snip--[

quoted

quoted

Note that I always have had a warning sowhere in acpi_pci_link_set during suspend:
 BUG: sleeping function called from invalid context at include/asm/semaphore.h:99

Bad.  If that's 100% reproducible, could you please try to nail it down?

I wasn't clear: I always had this "BUG: sleeping function called ...." since one year
or more. It never prevents from suspending. Do you want me to track down what cause 
this message?

Something like that, more or less, but the trace below shows this. ;-)
It doesn't seem to be harmful, though.

Here is a more complete trace: 

 Stopping tasks: ================|
 Shrinking memory...  ^H-^H\^Hdone (10908 pages freed)

]--snip--[

 Suspending device platform
 swsusp: Need to copy 60817 pages
 Intel machine check architecture supported.
 Intel machine check reporting enabled on CPU#0.
 BUG: sleeping function called from invalid context at include/asm/semaphore.h:99
 in_atomic():0, irqs_disabled():1
  [<c0103894>] show_trace_log_lvl+0x12/0x25
  [<c0103975>] show_trace+0xd/0x10
  [<c01040aa>] dump_stack+0x19/0x1b
  [<c0112ef9>] __might_sleep+0x8d/0x95
  [<c01daf53>] acpi_os_wait_semaphore+0x93/0x158
  [<c01ffb9d>] acpi_ut_acquire_mutex+0x69/0xd4
  [<c01f3231>] acpi_ns_get_node+0x8e/0x112
  [<c01f259a>] acpi_ns_evaluate+0x62/0x258
  [<c01f8aa1>] acpi_rs_set_srs_method_data+0xf1/0x125
  [<c01f8341>] acpi_set_current_resources+0x8b/0xb0
  [<c0204ca5>] acpi_pci_link_set+0x10e/0x1e0
  [<c0204dc2>] irqrouter_resume+0x4b/0x62

Here we go.  linux-acpi added to the Cc list.

  [<c021d04a>] __sysdev_resume+0x14/0x57
  [<c021d1c0>] sysdev_resume+0x19/0x4b
  [<c0221bf9>] device_power_up+0x8/0xf
  [<c0134271>] swsusp_suspend+0x51/0x78
  [<c013466a>] pm_suspend_disk+0x51/0xe2
  [<c01337d0>] enter_state+0x52/0x164
  [<c0133968>] state_store+0x86/0x9c
  [<c01831b8>] subsys_attr_store+0x20/0x25
  [<c01832c8>] sysfs_write_file+0xaa/0xcf
  [<c015472c>] vfs_write+0x8c/0x138
  [<c0154c44>] sys_write+0x3b/0x60
  [<c0102c2d>] sysenter_past_esp+0x56/0x8d
  =======================

]--snip--[

quoted

quoted

Or must really netconsole be stopped during device_suspend ?

Yes, it must.  For now, the consoles are suspend-unfriendly, so to speak. ;-)

I think I found something related to netconsole and your patch 
"suspend_console/resume_console". I was booting to runlevel 1 and I was using 
this script to suspend:

<=== script begin ===>
#!/bin/sh
# don't want to {fsck *and* reboot} if something goes wrong
mount -oremount,ro /
# enable write caching on HD
hdparm -W1 /dev/hd[ab]
echo 6 > /proc/sys/kernel/printk
sleep 2
echo disk > /sys/power/state
<=== script end ===>

The important point is the "sleep 2" line. If it is present, I can suspend the box.
Remove the "sleep command" and it will hang after displaying:
   Stopping tasks: =====================|
   Shrinking memory... done (0 pages freed)

If netconsole is disabled (ie not called from command line), I do not need this  
"sleep", suspend always works. 

It behaves like that with the "suspend_console/resume_console" patch or
without it?

Rafael


-- 
You never change things by fighting the existing reality.
		R. Buckminster Fuller
-
To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html