Re: [PATCH 4/6] ehea: header files

Michael Ellerman wrote:

On Sat, 2006-08-12 at 07:40 +1000, Anton Blanchard wrote:

quoted

Hi,

quoted

 drivers/net/ehea/ehea.h    |  452 
+#define EHEA_DRIVER_NAME	"IBM eHEA"

You are using this for ethtool get_drvinfo. Im not sure if it should
match the module name, and I worry about having a space in the name. Any
ideas on what we should be doing here?

I believe it must match the module name. It also might be nice to call
it "DRV_NAME" like most other network drivers do.

cheers

We rename EHEA_DRIVER_NAME to DRV_NAME (and EHEA_DRIVER_VERSION
to DRV_VERSION) and assign "ehea" to it

Jan-Bernd