Thread (43 messages) 43 messages, 3 authors, 2006-08-31

Re: [PATCH 22/26] ixgb: Cache-align all TX components of the adapter struct.

From: Auke Kok <hidden>
Date: 2006-08-29 22:40:56

Jeff Garzik wrote:
Eric Dumazet wrote:
quoted
On Tuesday 29 August 2006 18:45, Kok, Auke wrote:
quoted
     /* TX */
-    struct ixgb_desc_ring tx_ring;
+    struct ixgb_desc_ring tx_ring ____cacheline_aligned;
     unsigned long timeo_start;
On UP, this would only enlarge the size of structure and might consume 
more cache lines...

 I guess ____cacheline_aligned_in_smp is preferred here.

(see include/linux/netdevice.h)
changed in our tree to ____cacheline_aligned_in_smp.

Thanks,

Auke
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help