Thread (43 messages) 43 messages, 3 authors, 2006-08-31

Re: [PATCH 15/26] e100: reduce time under spinlock

From: Auke Kok <hidden>
Date: 2006-08-29 22:30:57

Jeff Garzik wrote:
Kok, Auke wrote:
quoted
We're waiting for a write flush to finish before unlocking, which
is not needed. Release the spinlock after the write command.

Signed-off-by: Auke Kok <redacted>
This undoes the following change:
ack, not good. Dropped it from the tree.

Auke


commit ad8c48ad3bbef078616ed4d2652d362dfd962f09
Author: Catalin(ux aka Dino) BOIE [off-list ref]
Date:   Sat Mar 4 12:18:59 2006 -0500

    Fix io ordering problems in e100

    Checking e100.c code against Documentation/io_ordering.txt I found the
    following problem:

    spin_lock_irq...
    write
    spin-unlock
    e100_write_flush

    The attached patch fix the code like this:

    spin_lock_irq...
    write
    e100_write_flush
    spin-unlock

    Signed-off-by: Catalin BOIE [off-list ref]
    Signed-off-by: Jeff Garzik [off-list ref]
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help