Re: BUG: warning at net/core/dev.c:1171/skb_checksum_help() 2.6.18-rc3
From: Herbert Xu <herbert@gondor.apana.org.au>
Date: 2006-08-03 09:57:14
On Thu, Aug 03, 2006 at 11:40:01AM +0200, Patrick McHardy wrote:
quoted
Are you sure? If ip_summed is CHECKSUM_COMPLETE then skb->csum is the checksum of the payload *without* the pseudo header.The pseudohdr is included indirectly through the tcp/udp checksum.
Yes of course, the payload gets balanced out by the header checksum, but not the pseudoheader. Now I get you :)
Yes, the 32-bit thing is a bug, I meant it works fine without inverting the checksum.
Right, I forgot about the checksum invariance under negation. In that case we can get rid of the tildes two lines down as well for consistency. Cheers, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmV>HI~} [off-list ref] Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt