Re: BUG: warning at net/core/dev.c:1171/skb_checksum_help() 2.6.18-rc3
From: Jamal Hadi Salim <hidden>
Date: 2006-08-01 12:55:24
From: Jamal Hadi Salim <hidden>
Date: 2006-08-01 12:55:24
On Tue, 2006-01-08 at 22:34 +1000, Herbert Xu wrote:
What I'd like to know is do we really need to preserve tc_verd/tc_index/input_dev for a packet crossing loopback's xmit function?
My instinctive reaction is to say no. Heres a (slightly complex) example: --> eth0(GSO ON) ---> lo --> eth1(GSO off) --> eth3(GSO ON) When we get to lo in the above graph, input_dev=eth0 and when we leave that info will be overwritten to be input_dev=lo. I just added the GSO markers (incase that info is useful) to show that we could move in the same topology between GSO and non-GSO devices. I believe it would be fine for lo not to preserve. Not sure if it is ok as a general rule though. cheers, jamal