Thread (53 messages) 53 messages, 9 authors, 2006-05-23

Re: [PATCH 2/2] ipg: redundancy with mii.h

From: David Vrabel <hidden>
Date: 2006-05-04 06:52:24
Also in: lkml

Francois Romieu wrote:
    ipg: remove forward declarations
    
    It makes no sense in a new driver.
    
    Signed-off-by: Francois Romieu [off-list ref]
Ack.
    ipg: replace #define with enum
    
    Added some underscores to improve readability.
    
    Signed-off-by: Francois Romieu [off-list ref]
Nack.  Register names in code should match those used in the 
documentation (even if they are a bit unreadable).  Though I will 
conceed that the available datasheet doesn't actually describe the 
majority of the registers.
    ipg: removal of useless #defines
    
    IPG_TX_NOTBUSY apart (one occurence in ipg.c), the #defines appear
    nowhere in the sources.
Ack.
    ipg: redundancy with mii.h - take II
    
    Replace a bunch of #define with their counterpart from mii.h
    
    It is applied to the usual MII registers this time.
Ack.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help