Re: [PATCH 1/8] [I/OAT] DMA memcpy subsystem

On 3/3/06, David S. Miller [off-list ref] wrote:

quoted

+static spinlock_t dma_list_lock;

Please use DEFINE_SPINLOCK().

quoted

+static void dma_chan_free_rcu(struct rcu_head *rcu) {

Newline before the brace please.

quoted

+static void dma_async_device_cleanup(struct kref *kref) {

Newline before the brace please.

quoted

+struct dma_chan_percpu
+{

Left brace on the same line as "struct dma_chan_percpu" please.

quoted

+struct dma_chan
+{

Similarly.

Otherwise this patch looks mostly ok.

Thanks Dave,

I'll apply these and other feedback and get updated patches generated.

- Chris