Re: [PATCH 1/8] [I/OAT] DMA memcpy subsystem

From: Chris Leech <redacted>
Date: Fri, 03 Mar 2006 13:42:20 -0800

+static spinlock_t dma_list_lock;

Please use DEFINE_SPINLOCK().

+static void dma_chan_free_rcu(struct rcu_head *rcu) {

Newline before the brace please.

+static void dma_async_device_cleanup(struct kref *kref) {

Newline before the brace please.

+struct dma_chan_percpu
+{

Left brace on the same line as "struct dma_chan_percpu" please.

+struct dma_chan
+{

Similarly.

Otherwise this patch looks mostly ok.