Re: [PATCH 5/6] x25: Allow 32 bit socket ioctl in 64 bit kernel
From: Shaun Pereira <hidden>
Date: 2006-02-16 05:42:41
Also in:
lkml
From: Shaun Pereira <hidden>
Date: 2006-02-16 05:42:41
Also in:
lkml
Thanks for that Aranaldo I have corrected this so as to be compliant with OSI Network services for DTE facilities and rebuilt and retested the patches Corrected patches follow. On Wed, 2006-02-15 at 20:35 -0200, Arnaldo Carvalho de Melo wrote:
On 2/15/06, Shaun Pereira [off-list ref] wrote:quoted
+ switch (*p) { + case X25_FAC_CALLING_AE: + if (p[1] > 33) + break; + dte_facs->calling_len = p[2]; + memcpy(dte_facs->calling_ae, &p[3], p[1] - 1); + *vc_fac_mask |= X25_MASK_CALLING_AE; + break;Can this '33' magic number be replaced with a define or sizeof(something)? - Arnaldo