Thread (3 messages) 3 messages, 2 authors, 2006-02-16

Re: [PATCH 5/6] x25: Allow 32 bit socket ioctl in 64 bit kernel

From: Arnaldo Carvalho de Melo <hidden>
Date: 2006-02-15 22:35:39
Also in: lkml

On 2/15/06, Shaun Pereira [off-list ref] wrote:
+               switch (*p) {
+                       case X25_FAC_CALLING_AE:
+                               if (p[1] > 33)
+                               break;
+                               dte_facs->calling_len = p[2];
+                               memcpy(dte_facs->calling_ae, &p[3], p[1] - 1);
+                               *vc_fac_mask |= X25_MASK_CALLING_AE;
+                               break;
Can this '33' magic number be replaced with a define or sizeof(something)?

- Arnaldo
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help