Thread (6 messages) flat view 6 messages, 3 authors, 2005-09-08

Re: [patch 1/1] ipw2100: remove by-hand function entry/exit debugging

From: Jeff Garzik <hidden>
Date: 2005-09-07 02:49:00
Also in: lkml

David S. Miller wrote:
From: Jeff Garzik <redacted>
Date: Tue, 06 Sep 2005 21:51:21 -0400

quoted
NAK.  Rationale: maintainer's choice.  Pavel doesn't get to choose
the debugger of choice for the driver maintainer.

If it makes the driver unreadable and thus harder to maintain,
I think such changes should seriously be considered.

Most of the DEBUG_INFO macro usage is fine, but those "enter"
and "exit" ones are just pure noise and should be removed.
I find them useful in my own drivers; they are definitely not pure noise.

	Jeff
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help