From: Jeff Garzik <hidden> Date: 2005-09-07 01:51:38
akpm@osdl.org wrote:
From: Pavel Machek <redacted>
This removes debug prints from entry/exit of functions. Such level of
debugging should probably be done by gdb or similar.
Signed-off-by: Pavel Machek <redacted>
Cc: Jeff Garzik <redacted>
Cc: "James P. Ketrenos" <redacted>
Signed-off-by: Andrew Morton <redacted>
NAK. Rationale: maintainer's choice. Pavel doesn't get to choose the
debugger of choice for the driver maintainer.
I do this entry/exit stuff in my net and SATA drivers; printk is my
primary method of debugging.
Jeff
NAK. Rationale: maintainer's choice. Pavel doesn't get to choose
the debugger of choice for the driver maintainer.
If it makes the driver unreadable and thus harder to maintain,
I think such changes should seriously be considered.
Most of the DEBUG_INFO macro usage is fine, but those "enter"
and "exit" ones are just pure noise and should be removed.
NAK. Rationale: maintainer's choice. Pavel doesn't get to choose
the debugger of choice for the driver maintainer.
If it makes the driver unreadable and thus harder to maintain,
I think such changes should seriously be considered.
Most of the DEBUG_INFO macro usage is fine, but those "enter"
and "exit" ones are just pure noise and should be removed.
I find them useful in my own drivers; they are definitely not pure noise.
Jeff
NAK. Rationale: maintainer's choice. Pavel doesn't get to choose
the debugger of choice for the driver maintainer.
If it makes the driver unreadable and thus harder to maintain,
I think such changes should seriously be considered.
Most of the DEBUG_INFO macro usage is fine, but those "enter"
and "exit" ones are just pure noise and should be removed.
I find them useful in my own drivers; they are definitely not pure noise.
gcc -finstrument-functions
can do that completely without adding noise to the sources.
been there, done that. With a gcc-patch you don't even need to
resolve symbols.
Regards
Ingo Oeser
I find them useful in my own drivers; they are definitely not pure noise.
gcc -finstrument-functions
I was going to mention this as well, and also the idea to
enable CONFIG_MCOUNT on a per-file basis.
We should never be doing by hand what can be automated.
I find them useful in my own drivers; they are definitely not pure noise.
gcc -finstrument-functions
I was going to mention this as well, and also the idea to
enable CONFIG_MCOUNT on a per-file basis.
We should never be doing by hand what can be automated.
As long as nobody breaks the primary maintainer's primary method of
debugging, patches are welcome...
Jeff