Re: [PATCH] Super TSO v3

On Mon, May 23, 2005 at 07:29:17PM -0700, David S. Miller wrote:

quoted

Should we skip this step if the socket has Nagle turned off?

No, that Nagle is trying to achieve something different (optimize
request/response type communication) compared to what we're doing
here (optimizing the number of transmit calls per byte during a
bulk transfer, without allowing the congestion window to empty
too much).

True, the Nagle algorithm itself aims to do something different
from this function.  However, the act of turning Nagle off is
an indication that the application wants to minimise the latency
by sending things out ASAP.  So we should either respect that
here by not delaying the packets to increase the TSO size, or
we'll need a new socket option to do that for TSO.

Cheers,
-- 
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} [off-list ref]
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt