Re: [2.6.11-rc4-mm1 patch] fix buggy IEEE80211_CRYPT_* selects
From: Adrian Bunk <hidden>
Date: 2005-03-02 22:09:34
Also in:
lkml
On Wed, Mar 02, 2005 at 02:12:04PM -0500, Jeff Garzik wrote:
Adrian Bunk wrote:quoted
On Wed, Mar 02, 2005 at 01:43:04AM -0500, Jeff Garzik wrote:quoted
Adrian Bunk wrote:quoted
+ select CRYPTO select CRYPTO_AES ---help--- Include software based cipher suites in support of IEEE 802.11i (aka TGi, WPA, WPA2, WPA-PSK, etc.) for use with CCMP enabled networks.@@ -54,10 +55,11 @@"ieee80211_crypt_ccmp". config IEEE80211_CRYPT_TKIP tristate "IEEE 802.11i TKIP encryption" depends on IEEE80211 + select CRYPTO select CRYPTO_MICHAEL_MIC'select CRYPTO_AES' should 'select CRYPTO' automatically, I would hope.This would result in a recursive dependency.No, it wouldn't. CRYPTO_AES depends on CRYPTO, which depends on nothing.
Exactly. And if CRYPTO_AES would select CRYPTO, you'd have a recursive dependency. The only possible thing would be to change all dependencies on CRYPTO to selects. This wouldn't be unlogical since the whole crypto subsystem is only a helper for other subsystems. James, any opinions on this issue?
Jeff
cu
Adrian
--
"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed