Thread (14 messages) 14 messages, 3 authors, 2005-03-03

Re: [2.6.11-rc4-mm1 patch] fix buggy IEEE80211_CRYPT_* selects

From: Andrew Morton <hidden>
Date: 2005-03-02 20:42:15
Also in: lkml

Jeff Garzik [off-list ref] wrote:
Adrian Bunk wrote:
quoted
On Wed, Mar 02, 2005 at 01:43:04AM -0500, Jeff Garzik wrote:
quoted
Adrian Bunk wrote:
quoted
+	select CRYPTO
select CRYPTO_AES
---help---
Include software based cipher suites in support of IEEE 802.11i 
(aka TGi, WPA, WPA2, WPA-PSK, etc.) for use with CCMP enabled 
networks.
@@ -54,10 +55,11 @@
"ieee80211_crypt_ccmp".

config IEEE80211_CRYPT_TKIP
tristate "IEEE 802.11i TKIP encryption"
depends on IEEE80211
+	select CRYPTO
select CRYPTO_MICHAEL_MIC

'select CRYPTO_AES' should 'select CRYPTO' automatically, I would hope.

This would result in a recursive dependency.
No, it wouldn't.  CRYPTO_AES depends on CRYPTO, which depends on nothing.
Thing is, CRYPTO_AES on only selectable on x86.

So really, IEEE80211_CRYPT_CCMP should depend upon CRYPTO_AES rather than
selecting it.  But that confuses users.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help