On Sat, 19 Feb 2005 12:43:43 +0100
Patrick McHardy [off-list ref] wrote:

The selector ports are initialized to fl_ip_sport/fl_ip_dport instead
of xfrm_flowi_sport(fl)/xfrm_flowi_dport(fl). This is wrong for ICMP,
type and code should be stored in sport and dport, in struct flowi both
are contained in fl_ip_sport.

This resulted in a long thread, many newer versions of the patch
trying to clean this up in other ways, but then we determined that
this original patch was the best and safest fix for now.

So I applied this first patch.

Thanks everyone.