Re: [XFRM]: Fix ICMP tempsel
From: Herbert Xu <herbert@gondor.apana.org.au>
Date: 2005-02-20 11:12:19
From: Herbert Xu <herbert@gondor.apana.org.au>
Date: 2005-02-20 11:12:19
On Sun, Feb 20, 2005 at 09:35:14AM +0100, Patrick McHardy wrote:
On second thought .. isn't there a risk of confusing userspace by changing the masks ?
It only affects xfrm_user users, of which I only know two -- Openswan and ip(8). Neither of which should care about it. However, I forgot to do the fixup in __xfrm[46]_init_tempsel and that is going to confuse the kernel itself :) It is looking more and more like a nasty hack though so maybe it's not worth it since the policy checks are still bloated enough even after we do this. Cheers, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmV>HI~} [off-list ref] Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt