Re: [patch 4/10] s390: network driver.
From: jamal <hidden>
Date: 2005-01-05 03:19:29
From: jamal <hidden>
Date: 2005-01-05 03:19:29
On Tue, 2005-01-04 at 18:28, Jeff Garzik wrote:
jamal wrote:quoted
The change is simple if theres consensus to go this path.Can you resend your patch?
I didnt send any patch - but heres one that looks right - havent tried compiling it.
My main objection was that any change should be made in the core, not in individual net drivers.
Attached patch resolves that concern
Another objection was that it seemed that some of the proposed solutions for clearing the queue on link down were imposing app-specific policy on the overall kernel. Aren't there cases where people would -not- want the queue to be cleared?
Thats a good question and your point of imposing policy in the kernel is valid. I know that i would probably want packets to appear they are going out when the wire is pulled from underneath me. Theres possibly people who would want it differently - so for we havent heard from them. Maybe poll far and wide - or push it in and wait for them to whine. cheers, jamal