Thread (67 messages) 67 messages, 8 authors, 2005-03-13

Re: [patch 4/10] s390: network driver.

From: Thomas Spatzier <hidden>
Date: 2004-12-22 10:56:06




Jeff Garzik [off-list ref] wrote on 20.12.2004 19:54:53:
I haven't heard anything to convince me that the same change should be
deployed across NNN drivers.  The drivers already signal the net core
that the link is down; to me, that implies there should be code in _one_
place that handles this condition, not NNN places.
This sounds plausible and I'm with Jeff here.
For me as the driver author it's the smallest change.
I will put it like this:
on cable gone:
      netif_stop_queue();
      netif_carrier_off();
on cable reconnected:
      netif_carrier_on();
      netif_wake_queue();

Is that ok, i.e. what all drivers do or should do?

For the problems that applications might have (i.e. sockets being
blocked etc.) another solution should be found.
And as Jeff pointed out, this should be a central solution and
not be implemented in drivers.

Regards,
Thomas.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help