Re: Patch: add loglevel to printk's in net/ipv4/route.c

On Thu, Dec 30, 2004 at 12:39:10AM +0100, Jesper Juhl wrote:

On Wed, 29 Dec 2004, Jesper Juhl wrote:

quoted

On Wed, 29 Dec 2004, Arnaldo Carvalho de Melo wrote:

quoted

Jörn Engel wrote:

quoted

On Wed, 29 December 2004 00:10:22 -0200, Arnaldo Carvalho de Melo wrote:

quoted

quoted

It doesn't make much difference, it's mostly for
completeness/correctness.

No, it does a helluva difference, give it a try :-)

hint: look for "\n"

hint2: Or the _lack_ of "\n" 8)

Ok, obviously something's wrong, but it's currently 03:44 here, so I'll 
take a look at it tomorrow (or quite possibly the day after since I have 
things to do).
Thank you for commenting, I'll dig into it at the first oppotunity I have.

Ok, this is a bit embarresing. Looking at the patch now after getting some 
sleep it's quite obvious that it is wrong. I should have slept on it 
before sending it - sorry for the noise people.

nothing to be sorry about, and thanks for all
the work you are doing for the linux kernel ...

best,
Herbert

-- 
Jesper Juhl