In article [ref] (at Wed, 9 Jun 2004 16:00:29 -0700), Shirley Ma [off-list ref] says:

Here is the patch against 2.6.6 kernel. Please review this patch.

Basically, I agree.
One thing: you can minimize diff using function declaration.

--yoshfuji