Re: [PATCH]Add new IPv6 MIBs counters support through netlink
From: YOSHIFUJI Hideaki / 吉藤英明 <hidden>
Date: 2004-05-26 23:08:28
From: YOSHIFUJI Hideaki / 吉藤英明 <hidden>
Date: 2004-05-26 23:08:28
In article [ref] (at Wed, 26 May 2004 13:44:15 -0700), "David S. Miller" [off-list ref] says:
On Wed, 26 May 2004 13:42:23 -0700 Shirley Ma [off-list ref] wrote:quoted
Yes, same structure ip_stats applys to IPv4 as well.Great, patch applied.
I failed to comment because I've just waken up... Hmm, why are you so hurrying? It on -rc stage and 2.6.7 is coming. Each people should moderate yourself... Sorry, please exclude it for now. Comments: Without adding support for u64 counter, it does not make sense to add new interface. You can add new counter to the end of the structures. This also contains per-interface statistics support. (I rember that you said that) we should add idev into an route and avoid get/put idev. I strongly do not want to poeple to change their code twice to support draft-ietf-ipv6-rfc2011-update-XX.txt. I personally think this should be included in 2.7 phase. --yoshfuji @ morning