Re: [PATCH] ax25 & netrom fixes for 2.6
From: David S. Miller <hidden>
Date: 2003-08-13 10:10:38
Also in:
linux-hams
From: David S. Miller <hidden>
Date: 2003-08-13 10:10:38
Also in:
linux-hams
On Tue, 12 Aug 2003 23:09:51 +0200 Jeroen Vreeken [off-list ref] wrote:
Since at the moment the only zero-copy path I can imagine is from packets over a bpq ethernet device wouldn't it be the easiest to just check at ax25_rcv() for non-linear packets and call skb_linearize() for them?
skb_linearize() is a deprecated interface, no new pieces of code should use it. If you want to mark the protocol as a new one you must do the non-linear handling properly just like every other protocol. Please, if you're going to be working in this area, fix this up properly and don't paper around the problems Stephen is showing to you.