On 2003.08.12 22:56:55 +0200 Stephen Hemminger wrote:

It looks like af_x25 is advertising itself as a new style protocol, yet
if
I walk the receive path:
	ax25_kiss_rcv -> ax25_rcv -> ax25_addr_parse
there is no place that checks that the address portion of the buffer
isn't fragmented
into a non_linear skb.

Since at the moment the only zero-copy path I can imagine is from packets
over a bpq ethernet device wouldn't it be the easiest to just check at
ax25_rcv() for non-linear packets and call skb_linearize() for them? That
way we would be safe untill we can make sure that the whole of the ax25
stack is non-linear safe?
Should I make a new patch with this included? (and possibly the ifconfig
problem you mentioned?)

Jeroen