On Saturday 28 March 2015 20:59:35 Dmitry Torokhov wrote:

On Tue, Mar 24, 2015 at 08:27:29AM +0100, Hans de Goede wrote:

quoted

Hi,

On 23-03-15 18:02, Pali Rohár wrote:

quoted

On Monday 23 March 2015 12:39:48 Hans de Goede wrote:

quoted

Hi,

On 22-03-15 14:46, Pali Rohár wrote:

quoted

This patch adds detection of trackstick for v7 protocol
devices. Code in this patch is used in official Dell
touchpad linux drivers for Dell models: Dell Latitude
E5250/5250, E5450/5450, E5550/5550

Detection code and base reg for alps v3 rushmore and v7
devices is exacly same.

Also user in bug
https://bugzilla.kernel.org/show_bug.cgi?id=94801 reported
that Toshiba Sattellite Z30-A-1DG has only alps v7 touchpad
device without trackstick and kernel reports to userspace
also redundant trackstick device.

Signed-off-by: Pali Rohár <redacted>

Looks good, but has this been tested on a laptop which
actually has a v7 pad + trackstick? I would like to see this
actually tested on at least one such laptop before it gets
merged.

Regards,

Hans

I did not tested my patch on any v7 touchpad-only laptop.

Ah, but I'm not worried about testing on a touchpad-only laptop,
we are already reporting a trackpoint there even though there
is none. I'm worried about breaking existing v7 using laptops
which actually have a trackstick.

So if this is tested on a v7 laptop with trackstick, and it
does not break the trackstick then that is good enough for me.

I wonder if Masaki might have devices with V7 and trackstick available
and could test the patch for us?

Thanks.

Masaki ping, do you have any V7 device with trackstick for testing?

-- 
Pali Rohár
pali.rohar@gmail.com