Re: [PATCH] Input: ALPS - Detect trackstick presence for v7 protocol
From: Pali Rohár <hidden>
Date: 2015-03-23 17:02:36
Also in:
linux-input
Attachments
- signature.asc [application/pgp-signature] 198 bytes
From: Pali Rohár <hidden>
Date: 2015-03-23 17:02:36
Also in:
linux-input
On Monday 23 March 2015 12:39:48 Hans de Goede wrote:
Hi, On 22-03-15 14:46, Pali Rohár wrote:quoted
This patch adds detection of trackstick for v7 protocol devices. Code in this patch is used in official Dell touchpad linux drivers for Dell models: Dell Latitude E5250/5250, E5450/5450, E5550/5550 Detection code and base reg for alps v3 rushmore and v7 devices is exacly same. Also user in bug https://bugzilla.kernel.org/show_bug.cgi?id=94801 reported that Toshiba Sattellite Z30-A-1DG has only alps v7 touchpad device without trackstick and kernel reports to userspace also redundant trackstick device. Signed-off-by: Pali Rohár <redacted>Looks good, but has this been tested on a laptop which actually has a v7 pad + trackstick? I would like to see this actually tested on at least one such laptop before it gets merged. Regards, Hans
I did not tested my patch on any v7 touchpad-only laptop. But I guess Dell should have tested it... Of course we can wait until somebody test this patch and after that we will merge it. @Santiago: Can you test this patch? You also have v7 touchpad only laptop (without trackstick). -- Pali Rohár pali.rohar@gmail.com