Re: [PATCH 1/5 V3] cgroup: remove redundate get/put of old css_set from migrate
From: Tejun Heo <tj@kernel.org>
Date: 2011-12-20 23:18:32
Also in:
cgroups
Hello, s/redundate/redundant/ in $SUBJ, right? On Tue, Dec 20, 2011 at 03:14:29PM -0800, Mandeep Singh Baines wrote:
Changes in V3: * Fixed to put error in retval (thanks Frederic Weisbecker) * https://lkml.org/lkml/2011/12/20/255 Changes in V2: * Updated commit message as per Tejun's feedback: * https://lkml.org/lkml/2011/12/19/289 -- >8 -- (snip)
Either put this as part of patch description or if you don't want it to be part of commit message, put it between --- and diffstat. Unfortunately, no tool understands "-- >8 --".
We can now assume that the css_set reference held by the task will not go away for an exiting task. PF_EXITING state can be trusted throughout migration by checking it after locking threadgroup. While at it, renamed css_set_check_fetched to css_set_fetched. !css_set_fetched() seems to read better than !css_set_check_fetched().
I don't feel too hot about the renaming. Can you please drop it for now?
Signed-off-by: Mandeep Singh Baines <redacted> Cc: Tejun Heo <tj@kernel.org> Cc: Li Zefan <redacted> Cc: containers@lists.linux-foundation.org Cc: cgroups@vger.kernel.org Cc: KAMEZAWA Hiroyuki <redacted> Cc: Frederic Weisbecker <redacted> Cc: Oleg Nesterov <oleg@redhat.com> Cc: Andrew Morton <akpm@linux-foundation.org> Cc: Paul Menage <redacted>
Other than that, looks good to me. I'll commit this once Li acks it. Thanks. -- tejun