Thread (64 messages) 64 messages, 3 authors, 8d ago

Re: [PATCH v5 43/58] objtool/klp: Test rejection of a file-local static branch key

From: Song Liu <song@kernel.org>
Date: 2026-09-16 21:39:54
Also in: sashiko-reviews

On Wed, Sep 16, 2026 at 12:00 PM [off-list ref] wrote:
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] invalid AI attribution tags in commit message
--

commit 31c30fc01ab7bac006cdecfa960b5321f80c4604
Author: Song Liu [off-list ref]

objtool/klp: Test rejection of a file-local static branch key

This commit adds a test to ensure that a static branch key owned by a
module is properly rejected when accessed via a livepatch relocation. It
adds a knob to cover file-local keys and verifies that the input references
the key through its section symbol.
quoted
Assisted-by: Claude:claude-opus-4
Based-on-test-by: Joe Lawrence [off-list ref]
Assisted-by: Claude:claude-opus-5
[Severity: Low]
This isn't a bug, but the commit message uses non-standard Assisted-by
tags with pseudonyms and no valid email addresses. Should these attribution
tags be removed or replaced with standard trailer formats before submission?
I think the Assisted-by tag here is OK.

Thanks,
Song
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help