Thread (77 messages) 77 messages, 3 authors, 17d ago

Re: [PATCH 50/58] objtool/klp: Add test for a static call introduced by the patch

From: sashiko-bot@kernel.org
Date: 2026-09-11 19:25:36

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] The commit message inaccurately describes the patch by claiming it modifies `test-jump-label-new-key` and drops a vmlinux export, which does not match the actual patch content.
--

commit b26ef30fbd576efdbe08e0ea26b0bf01b92ab1b4
Author: Song Liu [off-list ref]

objtool/klp: Add test for a static call introduced by the patch

This commit adds a new test script to cover a case where a patch introduces
a static call to a function which previously had none. It verifies that a new
vmlinux key is accepted while a new module-owned key is rejected.
Extend test-jump-label-new-key with the module half of the same question.
That needed the vmlinux export dropped first -- while the key is exported
it is reachable and being new changes nothing, so the first version of that
addition passed for the wrong reason. klp-build unit test corpus.
[Severity: Medium]
Does this paragraph belong in the commit message for this patch?

The text describes modifications to test-jump-label-new-key and dropping a
vmlinux export, but the actual patch consists entirely of adding the new file
tools/objtool/tests/generic/test-static-call-new.sh. 

The description also ends abruptly with "klp-build unit test corpus."

Could the commit message be updated to match the contents of the patch?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260911185031.1534046-1-song@kernel.org?part=50
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help