Thread (18 messages) flat view 18 messages, 4 authors, 5h ago

Re: [PATCH RFC 1/8] ftrace: Let ftrace_call_adjust() reject a patch site

From: Jose Fernandez (Anthropic) <hidden>
Date: 2026-09-06 20:41:14
Also in: bpf, linux-efi, linux-kbuild, linux-trace-kernel, lkml, llvm, rust-for-linux

On Fri, 4 Sep 2026 08:47:28 -0400, Steven Rostedt wrote:
The above could use a comment to why addr could be zero (I didn't even
realize some architectures do that).

	/* Some architectures may return zero for mis-aligned addresses */
Will add one in v2, thanks.

Today arm64 returns 0 only for a mis-aligned patch site. But patch 4 of
this series replaces that check with two: the two NOPs to patch must be
there, and the ops pointer must fit in the prefix NOPs (which also
catches a mis-aligned site). How about this to cover the series?

	/* The architecture may return 0 to reject a patch site */

Happy to name the mis-aligned case in patch 1 and extend the comment
in patch 4 if you prefer that.

Thanks,
Jose
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help