Re: [PATCH] selftests/livepatch: add test skip handling
From: Kamalesh Babulal <hidden>
Date: 2019-07-15 06:50:46
Also in:
linux-kselftest
From: Kamalesh Babulal <hidden>
Date: 2019-07-15 06:50:46
Also in:
linux-kselftest
On 7/14/19 7:58 PM, Joe Lawrence wrote:
Before running a livpeatch self-test, first verify that we've built and installed the livepatch self-test kernel modules by running a 'modprobe --dry-run'. This should catch a few environment issues, including !CONFIG_LIVEPATCH and !CONFIG_TEST_LIVEPATCH. In these cases, exit gracefully with test-skip status rather than test-fail status. Reported-by: Jiri Benc <redacted> Suggested-by: Shuah Khan <shuah@kernel.org> Signed-off-by: Joe Lawrence <joe.lawrence@redhat.com>
Reviewed-by: Kamalesh Babulal <redacted> [...]
+function assert_mod() {
+ local mod="$1"
+
+ if ! modprobe --dry-run "$mod" &>/dev/null ; thenJust a preference comment, shorter version 'modprobe -q -n' can be used here. Thanks, Kamalesh