Thread (16 messages) 16 messages, 6 authors, 1d ago

RE: [net-next,PATCH 2/2] enetc: Make eMDIO MDC rate configurable from DT

flat view

From: Wei Fang <wei.fang@nxp.com>
Date: 2026-10-23 02:08:06
Also in: imx, linux-arm-kernel, linux-devicetree, lkml, netdev

quoted
quoted
quoted
Your first patch only modified the EMDIO binding-doc, not the
ENETC and switch binding-doc.
So I need to patch also
Documentation/devicetree/bindings/net/dsa/mscc,ocelot.yaml ? Any
other binding document ?
fsl,enetc.yaml and nxp,netc-switch.yaml.

However, once again, I don't highly recommend adding a clocks property
to the DTS to obtain the MDC source clock frequency. My reasons are as
follows:
quoted
1. The MDC source clock is the NETC system clock, which is a fixed
configuration with a fixed frequency for each SoC, hardcode the rate in driver
is simpler.

In the RCW project (https://github.com/nxp-qoriq/rcw), we have for LS1028A:
- R_SQPP_0x85bb/rcw_800_sdboot.rcw and
R_SQPP_0x85bb/rcw_800_emmcboot.rcw:
  set CGA_PLL2_RAT=8, giving 800 / 3 = 266.67 MHz.
- R_SQPP_0x85bb/rcw_1500_gpu700.rcw: sets CGA_PLL2_RAT=14, giving 1400
/ 3 =
  466.67 MHz.

Apart from these, yes, the other RCWs do set CGA_PLL2_RAT=12, giving 400
MHz.
But the statement in general is false.
Okay, it seems that the LS1028A is a special case. For i.MX, we set the NETC to
a fixed operating frequency for each SoC and do not modify it. Therefore, it is
more appropriate to leave the LS1028A as is for now.

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help