Re: [net-next,PATCH 2/2] enetc: Make eMDIO MDC rate configurable from DT
flat view
From: Andrew Lunn <andrew@lunn.ch>
Date: 2026-10-16 20:59:49
Also in:
imx, linux-arm-kernel, linux-devicetree, lkml, netdev
quoted hunk ↗ jump to hunk
+ div = ((clk_get_rate(enet_clk) / mdc_freq) - 1) / 4; + if (div < 5 || div > 0x1ff) + return dev_err_probe(dev, -EINVAL, + "Requested MDC frequency is out of range, ignoring\n");
Returning -EINVAL is not really 'ignoring' the invalid value. Since these are optional properties which are present, if they are not valid returning an error is good. So please fix the message. Why is dev < 5 an issue? Andrew