[PATCH v5 5/9] keys/trusted_keys: fix PKWM output buffer cleanup
flat view
HOTtoday
From: Srish Srinivasan <ssrish@linux.ibm.com>
Date: 2026-10-18 17:10:11
Also in:
keyrings, linux-integrity, linux-security-module, lkml, stable
Subsystem:
keys-trusted, keys-trusted-plpks, keys/keyrings, security subsystem, the rest · Maintainers:
James Bottomley, Jarkko Sakkinen, Mimi Zohar, Srish Srinivasan, Nayna Jain, David Howells, Paul Moore, James Morris, "Serge E. Hallyn", Linus Torvalds
Revision v5 of 5 in this series.
Revisions (5)
The PKWM seal and unseal paths unconditionally free their output buffers,
but the PLPKS helpers can return without initializing those pointers.
Initialize the output buffer pointers to NULL to make cleanup safe on early
failure paths.
Fixes: c99fcb0d735b ("keys/trusted_keys: establish PKWM as a trusted source")
Cc: stable@vger.kernel.org # 7.0
Signed-off-by: Srish Srinivasan <ssrish@linux.ibm.com>
---
security/keys/trusted-keys/trusted_pkwm.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/security/keys/trusted-keys/trusted_pkwm.c b/security/keys/trusted-keys/trusted_pkwm.c
index 633a7674d065..7345f233eb74 100644
--- a/security/keys/trusted-keys/trusted_pkwm.c
+++ b/security/keys/trusted-keys/trusted_pkwm.c@@ -82,7 +82,7 @@ static int trusted_pkwm_seal(struct trusted_key_payload *p, char *datablob) { struct trusted_key_options *options = NULL; struct trusted_pkwm_options *pkwm = NULL; - u8 *input_buf, *output_buf; + u8 *input_buf, *output_buf = NULL; u64 output_len, input_len; int rc;
@@ -129,7 +129,7 @@ static int trusted_pkwm_seal(struct trusted_key_payload *p, char *datablob) static int trusted_pkwm_unseal(struct trusted_key_payload *p, char *datablob) { - u8 *input_buf, *output_buf; + u8 *input_buf, *output_buf = NULL; u64 input_len, output_len; int rc;
--
2.52.0