[PATCH v5 0/9] Extend PKWM to support user-created wrapping keys
flat view
HOTtoday
From: Srish Srinivasan <ssrish@linux.ibm.com>
Date: 2026-10-18 17:09:18
Also in:
keyrings, linux-integrity, linux-security-module, lkml
Revision v5 of 5 in this series.
Revisions (5)
The PKWM trusted source currently uses a single default wrapping key per LPAR. This key is created during trusted source initialization, and all trusted keys backed by PKWM are sealed and unsealed using it. Recent versions of PKWM allow users to create and manage their own wrapping keys through a set of lifecycle operations. This patch series brings these PKWM capabilities into the kernel, allowing users to create, manage, and select wrapping keys for sealing their trusted keys, rather than requiring all trusted keys to use the default wrapping key. This series extends PKWM to support user-created wrapping keys. It adds the required HCALLs, allows users to select a wrapping key by label when creating PKWM-backed trusted keys, and introduces a sysfs interface for managing wrapping keys from userspace. This patchset also includes six preparatory fixes. These correct double conversion of PLPKS write, remove, and wrapping key flush errors; align wrapping length types with the underlying HCALL interfaces; preserve the original error returned when default wrapping key generation fails; initialize PKWM output buffer pointers before cleanup; and clear sensitive PKWM seal and unseal buffers before freeing them. This series depends on the following PLPKS refactoring and hardening series and must be applied on top of it: https://lore.kernel.org/all/20260923182816.151451-1-ssrish@linux.ibm.com/ (local) Changelog: v4 -> v5: - Addressed issues reported by Sashiko - Added HCALL-defined length validation for wrapping operations - Cleared stale PLPKS sysfs kobject pointers on initialization failure - Documented "default-wrapping-key" as a reserved label without assuming it exists - Dropped Tested-by tags from modified patches v3 -> v4: - Addressed issues reported by Sashiko - Fixed double conversion of PLPKS object flush errors - Initialized PKWM output buffer pointers before cleanup - Corrected the documented H_PKS_GET_OBJECTLABELS output field order - Prevented stale policy use and caller data modification during revocation checks - Fixed wrapping key sysfs kobject cleanup - Restricted wrapping key sysfs initialization to pseries - Dropped Tested-by tags from modified patches v2 -> v3: - Moved most of the refactoring and hardening patches into a separate series: https://lore.kernel.org/all/20260923182816.151451-1-ssrish@linux.ibm.com/ (local) - Added a fix to clear sensitive PKWM seal and unseal buffers before freeing them - Added Nageswara's Tested-by tag - Refined error handling and documented default wrapping key restrictions v1 -> v2: - Addressed parameter validation issues reported by Nageswara - Tweaked PLPKS_WRAPKEY_SYSFS Kconfig help text - Added two preparatory bug-fix patches - Cc'd stable@vger.kernel.org where applicable Srish Srinivasan (9): pseries/plpks: fix double conversion of write and remove flush errors pseries/plpks: fix double conversion of wrapping key flush errors pseries/plpks: fix length types for wrapping operations keys/trusted_keys: propagate wrapping key generation errors keys/trusted_keys: fix PKWM output buffer cleanup keys/trusted_keys: clear sensitive PKWM buffers pseries/plpks: add HCALLs for PKWM wrapping key life cycle management keys/trusted_keys: enable PKWM wrapping key selection by label pseries/plpks/wrapkey: expose PKWM wrapping key management to userspace via sysfs .../ABI/testing/sysfs-firmware-plpks | 113 ++++ Documentation/arch/powerpc/papr_hcalls.rst | 33 ++ .../security/keys/trusted-encrypted.rst | 4 +- arch/powerpc/include/asm/hvcall.h | 5 +- arch/powerpc/include/asm/plpks.h | 40 +- arch/powerpc/platforms/pseries/Kconfig | 15 + arch/powerpc/platforms/pseries/Makefile | 1 + arch/powerpc/platforms/pseries/plpks-sysfs.c | 14 + .../platforms/pseries/plpks-wrapkey-sysfs.c | 408 +++++++++++++ arch/powerpc/platforms/pseries/plpks.c | 536 ++++++++++++++++-- include/keys/trusted_pkwm.h | 3 + security/keys/trusted-keys/trusted_pkwm.c | 52 +- 12 files changed, 1164 insertions(+), 60 deletions(-) create mode 100644 arch/powerpc/platforms/pseries/plpks-wrapkey-sysfs.c -- 2.52.0