Re: [PATCH for-linus] PCI/AER: Skip error recovery on false alarms

From
Perlow, Jason <hidden>
Date
2026-10-08 22:02:22
Also in
amd-gfx, linux-pci
Reply to
Perlow, Jason, 2026-10-08
Hi Bjorn, Lukas, and Thorsten,

I tested the standalone false-alarm recovery patch on my
MacBookPro16,1. Unfortunately, the power-off issue still reproduces.

The candidate was based on v7.3-rc6, with eddba19b8b5f retained and
your posted patch applied. This was our T2-patched kernel, not
vanilla; no additional T2-specific AER workaround was included.

The test kernel, 7.3.0-rc6-5-t2-edge-anfe-wunner-test, reached the GUI
and then powered off. Its identity is independently confirmed by SSH
and the retained kernel banner and command line.

Before hardware testing, image checks, module dependency/version
validation, T2 companion-module builds, and an EFI/KVM boot passed.
Those checks did not predict the physical failure.

The retained journal ends at approximately 3.55 seconds, before the
observed GUI/power-off event. It contains no recorded AER/GHES error,
panic, oops, or shutdown sequence, and no pstore records were
recovered. Consequently, I cannot establish the precise shutdown
mechanism from these logs.

One comparison caveat: the candidate used GCC 16.2; the known-good
release used GCC 14.

I have restored the kernel with the full ANFE revert, and the machine
is back online. Based on this test, I cannot confirm that the
standalone fix resolves the MacBookPro16,1 regression.

Regards, Jason


On Thu, Oct 8, 2026 at 3:51 PM Perlow, Jason [off-list ref] wrote:
I will test the patch on MacBook 16,1 on RC6. Stand by.


On Thu, Oct 8, 2026 at 3:33 PM Bjorn Helgaas [off-list ref] wrote:
quoted
On Thu, Oct 08, 2026 at 03:23:34PM -0400, Alex Deucher wrote:
quoted
On Thu, Oct 8, 2026 at 3:17 PM Bjorn Helgaas [off-list ref] wrote:
quoted
On Thu, Oct 08, 2026 at 02:26:00PM +0200, Lukas Wunner wrote:
quoted
Alex is seeing a probe failure of the amdgpu driver after the Root Port
above an AMD Navi10 GPU has been reset.  The reset was performed to
recover from a Firmware First reported Fatal Error.

However all status registers in the Root Port's AER Extended Capability
are blank, so apparently the platform firmware raised a false alarm.

The issue is only occurring since commit eddba19b8b5f ("PCI/AER: Support
Advisory Non-Fatal Errors").  It looks like enabling Advisory Non-Fatal
Errors causes code paths to be exercised in platform firmware which
were never validated before.

Skip error recovery on false alarms, i.e. if no unmasked errors were
actually signaled.

Note that this will also skip recovery if both the Status and Mask
registers are "all ones", as would be the case for inaccessible devices.
However that seems justified because it would imply either a hot-unplug
event or a Surprise Down Error further up in the hierarchy.  Interfering
with recovery from that seems uncalled for.

Fixes: eddba19b8b5f ("PCI/AER: Support Advisory Non-Fatal Errors")
Reported-by: Alex Deucher <alexander.deucher@amd.com>
Tested-by: Alex Deucher <alexander.deucher@amd.com>
Closes: https://bugzilla.kernel.org/show_bug.cgi?id=222095
Signed-off-by: Lukas Wunner <lukas@wunner.de>
Applied to pci/for-linus for v7.3, thanks!  I dropped Alex's Tested-by
since he hasn't tested this change by itself.
FWIW, I just tested this patch by itself and it works as expected.
Feel free to add:
Tested-by: Alex Deucher <alexander.deucher@amd.com>
Acked-by: Alex Deucher <alexander.deucher@amd.com>
Added, thanks very much!


--
Jason Perlow | Argonaut Media Communications

Voice/Text  (954) 242-3484 | jperlow@gmail.com | Blog: techbroiler.net
Read my Tech and Food Industry articles: https://linktr.ee/jperlow
Bluesky: https://bsky.app/profile/jperlow.bsky.social

Need to schedule a meeting with me? https://bit.ly/3y8P3Gp


-- 
Jason Perlow | Argonaut Media Communications

Voice/Text  (954) 242-3484 | jperlow@gmail.com | Blog: techbroiler.net
Read my Tech and Food Industry articles: https://linktr.ee/jperlow
Bluesky: https://bsky.app/profile/jperlow.bsky.social

Need to schedule a meeting with me? https://bit.ly/3y8P3Gp

Attachments

Thread (13 messages) 13 messages, 5 authors, last reply 2026-10-12
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help