Re: [PATCH for-linus] PCI/AER: Skip error recovery on false alarms

From
Bjorn Helgaas <helgaas@kernel.org>
Date
2026-10-08 19:33:58
Also in
amd-gfx, linux-pci
Reply to
Alex Deucher, 2026-10-08
On Thu, Oct 08, 2026 at 03:23:34PM -0400, Alex Deucher wrote:
On Thu, Oct 8, 2026 at 3:17 PM Bjorn Helgaas [off-list ref] wrote:
quoted
On Thu, Oct 08, 2026 at 02:26:00PM +0200, Lukas Wunner wrote:
quoted
Alex is seeing a probe failure of the amdgpu driver after the Root Port
above an AMD Navi10 GPU has been reset.  The reset was performed to
recover from a Firmware First reported Fatal Error.

However all status registers in the Root Port's AER Extended Capability
are blank, so apparently the platform firmware raised a false alarm.

The issue is only occurring since commit eddba19b8b5f ("PCI/AER: Support
Advisory Non-Fatal Errors").  It looks like enabling Advisory Non-Fatal
Errors causes code paths to be exercised in platform firmware which
were never validated before.

Skip error recovery on false alarms, i.e. if no unmasked errors were
actually signaled.

Note that this will also skip recovery if both the Status and Mask
registers are "all ones", as would be the case for inaccessible devices.
However that seems justified because it would imply either a hot-unplug
event or a Surprise Down Error further up in the hierarchy.  Interfering
with recovery from that seems uncalled for.

Fixes: eddba19b8b5f ("PCI/AER: Support Advisory Non-Fatal Errors")
Reported-by: Alex Deucher <alexander.deucher@amd.com>
Tested-by: Alex Deucher <alexander.deucher@amd.com>
Closes: https://bugzilla.kernel.org/show_bug.cgi?id=222095
Signed-off-by: Lukas Wunner <lukas@wunner.de>
Applied to pci/for-linus for v7.3, thanks!  I dropped Alex's Tested-by
since he hasn't tested this change by itself.
FWIW, I just tested this patch by itself and it works as expected.
Feel free to add:
Tested-by: Alex Deucher <alexander.deucher@amd.com>
Acked-by: Alex Deucher <alexander.deucher@amd.com>
Added, thanks very much!
Thread (13 messages) 13 messages, 5 authors, last reply 2026-10-12
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help