[RFC 07/12] powerpc/pseries: Annotate the RTAS physical-attestation sequence lock context
From: "Ritesh Harjani (IBM)" <ritesh.list@gmail.com>
Date: 2026-09-27 14:35:05
Also in:
lkml
Subsystem:
linux for powerpc (32-bit and 64-bit), the rest · Maintainers:
Madhavan Srinivasan, Linus Torvalds
Clang's context analysis reports:
papr-phy-attest.c:154:1: error: mutex 'rtas_ibm_physical_attestation_lock' is still held at the end of function [-Werror,-Wthread-safety-analysis]
papr-phy-attest.c:169:2: error: releasing mutex 'rtas_ibm_physical_attestation_lock' that was not held [-Werror,-Wthread-safety-analysis]
Add the necessary annotations to phy_attest_sequence_{begin|end}(),
to fix these errors for enabling Clang context analysis.
Signed-off-by: Ritesh Harjani (IBM) <ritesh.list@gmail.com>
---
arch/powerpc/platforms/pseries/papr-phy-attest.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/arch/powerpc/platforms/pseries/papr-phy-attest.c b/arch/powerpc/platforms/pseries/papr-phy-attest.c
index 350ba26e5962..d2bc5c0da422 100644
--- a/arch/powerpc/platforms/pseries/papr-phy-attest.c
+++ b/arch/powerpc/platforms/pseries/papr-phy-attest.c@@ -133,8 +133,11 @@ static int rtas_physical_attestation(struct rtas_phy_attest_params *params) * @seq: user specified parameters for RTAS call from seq struct. * * Context: May sleep. + * Returns with rtas_ibm_physical_attestation_lock held. + * phy_attest_sequence_end() releases it. */ static void phy_attest_sequence_begin(struct papr_rtas_sequence *seq) + __acquires(&rtas_ibm_physical_attestation_lock) { struct rtas_phy_attest_params *param;
@@ -161,6 +164,7 @@ static void phy_attest_sequence_begin(struct papr_rtas_sequence *seq) * Releases resources obtained by phy_attest_sequence_begin(). */ static void phy_attest_sequence_end(struct papr_rtas_sequence *seq) + __releases(&rtas_ibm_physical_attestation_lock) { struct rtas_phy_attest_params *param;
--
2.39.5