[RFC 05/12] powerpc/pseries: Annotate the VPD sequence lock context
From: "Ritesh Harjani (IBM)" <ritesh.list@gmail.com>
Date: 2026-09-27 14:35:20
Also in:
lkml
Subsystem:
linux for powerpc (32-bit and 64-bit), the rest · Maintainers:
Madhavan Srinivasan, Linus Torvalds
Clang's context analysis reports:
papr-vpd.c:151:1: error: mutex 'rtas_ibm_get_vpd_lock' is still held at the end of function [-Werror,-Wthread-safety-analysis]
papr-vpd.c:165:2: error: releasing mutex 'rtas_ibm_get_vpd_lock' that was not held [-Werror,-Wthread-safety-analysis]
Add the necessary annotations to in vpd_sequence_{begin|end}(),
to fix these errors for enabling Clang context analysis.
Signed-off-by: Ritesh Harjani (IBM) <ritesh.list@gmail.com>
---
arch/powerpc/platforms/pseries/papr-vpd.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/arch/powerpc/platforms/pseries/papr-vpd.c b/arch/powerpc/platforms/pseries/papr-vpd.c
index f38c188fc4a1..8d210454cff1 100644
--- a/arch/powerpc/platforms/pseries/papr-vpd.c
+++ b/arch/powerpc/platforms/pseries/papr-vpd.c@@ -123,8 +123,10 @@ static int rtas_ibm_get_vpd(struct rtas_ibm_get_vpd_params *params) * @seq: vpd call parameters from sequence struct * * Context: May sleep. + * Returns with rtas_ibm_get_vpd_lock held. vpd_sequence_end() releases it. */ static void vpd_sequence_begin(struct papr_rtas_sequence *seq) + __acquires(&rtas_ibm_get_vpd_lock) { struct rtas_ibm_get_vpd_params *vpd_params; /*
@@ -157,6 +159,7 @@ static void vpd_sequence_begin(struct papr_rtas_sequence *seq) * Releases resources obtained by vpd_sequence_begin(). */ static void vpd_sequence_end(struct papr_rtas_sequence *seq) + __releases(&rtas_ibm_get_vpd_lock) { struct rtas_ibm_get_vpd_params *vpd_params;
--
2.39.5