Thread (63 messages) 63 messages, 13 authors, 15h ago

Re: [PATCH 31/42] ASoC: cix-ipbloq: Use devm_of_reserved_mem_device_init()

From: Gary Yang <hidden>
Date: 2026-07-07 01:36:47
Also in: dri-devel, imx, linux-arm-msm, linux-aspeed, linux-devicetree, linux-media, linux-mediatek, linux-mips, linux-mmc, linux-remoteproc, linux-sound, linux-staging, linux-sunxi, linux-tegra, lkml, openbmc

On 2026-07-04 01:08, Mukesh Ojha wrote:
quoted hunk ↗ jump to hunk
[Some people who received this message don't often get email from mukesh.ojha@oss.qualcomm.com. Learn why this is important at https://aka.ms/LearnAboutSenderIdentification ]

EXTERNAL EMAIL

Use the devres-managed devm_of_reserved_mem_device_init() to ensure
the reserved memory region is released on device removal, fixing a
missing cleanup in the original code.

Signed-off-by: Mukesh Ojha <redacted>
---
 sound/hda/controllers/cix-ipbloq.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/sound/hda/controllers/cix-ipbloq.c b/sound/hda/controllers/cix-ipbloq.c
index c1084a915c13..815932e5c58b 100644
--- a/sound/hda/controllers/cix-ipbloq.c
+++ b/sound/hda/controllers/cix-ipbloq.c
@@ -257,7 +257,7 @@ static int cix_ipbloq_hda_probe(struct platform_device *pdev)

        dma_set_mask_and_coherent(hda->dev, DMA_BIT_MASK(32));

-       err = of_reserved_mem_device_init(hda->dev);
+       err = devm_of_reserved_mem_device_init(hda->dev);
        if (err < 0 && err != -ENODEV) {
                dev_err(hda->dev,
                        "failed to init reserved mem for DMA, err = %d\n", err);
Reviewed-by: Gary Yang <redacted>
--
2.53.0
  
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help