Re: [PATCH 40/42] misc: fastrpc: Use devm_of_reserved_mem_device_init()
From: Ekansh Gupta <hidden>
Date: 2026-07-06 04:55:59
Also in:
dri-devel, imx, linux-arm-kernel, linux-arm-msm, linux-aspeed, linux-devicetree, linux-media, linux-mediatek, linux-mmc, linux-remoteproc, linux-sound, linux-staging, linux-sunxi, linux-tegra, lkml, openbmc
On 06-07-2026 01:10, Mukesh Ojha wrote:
Use the devres-managed devm_of_reserved_mem_device_init() to ensure the reserved memory region is released on device removal, fixing a missing of_reserved_mem_device_release() in fastrpc_rpmsg_remove().
nit: I see this change is also fixing fastrpc_rpmsg_probe() early failure leaks as well as -EPROBE_DEFER retry paths which could be added to the commit message. Reviewed-by: Ekansh Gupta <redacted>
quoted hunk ↗ jump to hunk
Signed-off-by: Mukesh Ojha <redacted> --- drivers/misc/fastrpc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)diff --git a/drivers/misc/fastrpc.c b/drivers/misc/fastrpc.c index d86e79134c68..c4e05b0db527 100644 --- a/drivers/misc/fastrpc.c +++ b/drivers/misc/fastrpc.c@@ -2396,7 +2396,7 @@ static int fastrpc_rpmsg_probe(struct rpmsg_device *rpdev) return -EINVAL; } - if (of_reserved_mem_device_init_by_idx(rdev, rdev->of_node, 0)) + if (devm_of_reserved_mem_device_init(rdev)) dev_info(rdev, "no reserved DMA memory for FASTRPC\n"); vmcount = of_property_read_variable_u32_array(rdev->of_node,