Thread (57 messages) 57 messages, 14 authors, 4d ago

Re: [PATCH 22/23] reset: rzg2l: use platform_device_set_of_node_from_dev()

From: Johan Hovold <johan@kernel.org>
Date: 2026-06-08 06:53:05
Also in: dri-devel, driver-core, imx, intel-xe, linux-arm-msm, linux-devicetree, linux-i2c, linux-iommu, linux-mips, linux-pm, linux-sound, linux-usb, lkml, netdev, platform-driver-x86

On Fri, Jun 05, 2026 at 05:54:11PM +0300, Andy Shevchenko wrote:
On Fri, Jun 05, 2026 at 02:18:49PM +0200, Johan Hovold wrote:
quoted
On Wed, Jun 03, 2026 at 12:52:52AM +0300, Andy Shevchenko wrote:
quoted
On Tue, Jun 02, 2026 at 10:24:41AM +0200, Philipp Zabel wrote:
quoted
On Do, 2026-05-21 at 10:36 +0200, Bartosz Golaszewski wrote:
...
quoted
quoted
quoted
quoted
-	device_set_of_node_from_dev(&vdev->dev, dev);
+	platform_device_set_of_node_from_dev(vdev, dev);
Same Q here, why it uses inherited call? Cargo cult?

'reused' flag is solely pin control (provider!) thingy as far as I remember.
No, it's needed for pin control *consumers*, which can be any device,
and potentially any other resource managed by driver core or bus code.
Why don't we set it for every pin control consumer automatically?
It must only be set on the second (child) one to prevent driver core
from trying to acquire resources already claimed by the parent.

Setting it on both would break things.

Johan
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help