Re: [PATCH 12/23] iommu/fsl: use platform_device_set_of_node()
From: Robin Murphy <robin.murphy@arm.com>
Date: 2026-05-21 09:44:50
Also in:
dri-devel, driver-core, imx, intel-xe, linux-arm-msm, linux-devicetree, linux-i2c, linux-iommu, linux-mips, linux-pm, linux-sound, linux-usb, lkml, netdev, platform-driver-x86
On 2026-05-21 9:36 am, Bartosz Golaszewski wrote:
Ahead of reworking the reference counting logic for platform devices, encapsulate the assignment of the OF node for dynamically allocated platform devices with the provided helper.
FWIW, Acked-by: Robin Murphy <robin.murphy@arm.com> Although I'm not sure the whole lot couldn't just be replaced with of_platform_device_create(), but then frankly this driver is on life support anyway as it only serves one very niche VFIO use-case and it's not clear whether it has any real mainline users left.
quoted hunk ↗ jump to hunk
Signed-off-by: Bartosz Golaszewski <redacted> --- drivers/iommu/fsl_pamu.c | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-)diff --git a/drivers/iommu/fsl_pamu.c b/drivers/iommu/fsl_pamu.c index 25aa477a95a95cb4fa4e132727cde0a936750ee2..012839fa0d8a27cafc6a441373f4f6da794388c1 100644 --- a/drivers/iommu/fsl_pamu.c +++ b/drivers/iommu/fsl_pamu.c@@ -973,7 +973,8 @@ static __init int fsl_pamu_init(void) ret = -ENOMEM; goto error_device_alloc; } - pdev->dev.of_node = of_node_get(np); + + platform_device_set_of_node(pdev, np); ret = pamu_domain_init(); if (ret)@@ -985,12 +986,10 @@ static __init int fsl_pamu_init(void) goto error_device_add; } + of_node_put(np); return 0; error_device_add: - of_node_put(pdev->dev.of_node); - pdev->dev.of_node = NULL; - platform_device_put(pdev); error_device_alloc: