Re: [PATCH 01/15] sched/idle: Handle offlining first in idle loop

From
Frederic Weisbecker <frederic@kernel.org>
Date
2026-01-20 14:52:19
Also in
linux-pm, linux-s390, lkml
Reply to
K Prateek Nayak, 2026-01-20
Le Tue, Jan 20, 2026 at 09:56:12AM +0530, K Prateek Nayak a écrit :
Hello Frederic, Peter,

On 1/20/2026 2:34 AM, Frederic Weisbecker wrote:
quoted
Le Mon, Jan 19, 2026 at 01:53:47PM +0100, Peter Zijlstra a écrit :
quoted
On Fri, Jan 16, 2026 at 03:51:54PM +0100, Frederic Weisbecker wrote:
quoted
 kernel/sched/idle.c | 11 ++++++-----
 1 file changed, 6 insertions(+), 5 deletions(-)
diff --git a/kernel/sched/idle.c b/kernel/sched/idle.c
index c174afe1dd17..35d79af3286d 100644
--- a/kernel/sched/idle.c
+++ b/kernel/sched/idle.c
@@ -260,6 +260,12 @@ static void do_idle(void)
 {
 	int cpu = smp_processor_id();
 
+	if (cpu_is_offline(cpu)) {
Does it make sense to make that: if (unlikely(cpu_is_offline(cpu))) ?
Yes indeed!
nit. but don't we inherit it from:

#define cpu_is_offline(cpu)     unlikely(!cpu_online(cpu))

so it will end up being annotated with unlikely() no?
Ah right!
-- 
Thanks and Regards,
Prateek
-- 
Frederic Weisbecker
SUSE Labs
Thread (41 messages) 41 messages, 8 authors, last reply 2026-02-25
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help