Re: [PATCH 07/15] cpufreq: ondemand: Simplify idle cputime granularity test
From: "Rafael J. Wysocki" <rafael@kernel.org>
Date: 2026-01-19 12:30:21
Also in:
linux-pm, linux-s390, lkml
On Fri, Jan 16, 2026 at 3:53 PM Frederic Weisbecker [off-list ref] wrote:
cpufreq calls get_cpu_idle_time_us() just to know if idle cputime accounting has a nanoseconds granularity. Use the appropriate indicator instead to make that deduction. Signed-off-by: Frederic Weisbecker <frederic@kernel.org>
Acked-by: Rafael J. Wysocki (Intel) <rafael@kernel.org> or please let me know if you want me to take this patch.
quoted hunk ↗ jump to hunk
--- drivers/cpufreq/cpufreq_ondemand.c | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-)diff --git a/drivers/cpufreq/cpufreq_ondemand.c b/drivers/cpufreq/cpufreq_ondemand.c index a6ecc203f7b7..2d52ee035702 100644 --- a/drivers/cpufreq/cpufreq_ondemand.c +++ b/drivers/cpufreq/cpufreq_ondemand.c@@ -334,17 +334,12 @@ static void od_free(struct policy_dbs_info *policy_dbs) static int od_init(struct dbs_data *dbs_data) { struct od_dbs_tuners *tuners; - u64 idle_time; - int cpu; tuners = kzalloc(sizeof(*tuners), GFP_KERNEL); if (!tuners) return -ENOMEM; - cpu = get_cpu(); - idle_time = get_cpu_idle_time_us(cpu, NULL); - put_cpu(); - if (idle_time != -1ULL) { + if (tick_nohz_enabled) { /* Idle micro accounting is supported. Use finer thresholds */ dbs_data->up_threshold = MICRO_FREQUENCY_UP_THRESHOLD; } else { --2.51.1