Re: [PATCH] bus: fsl-mc: add missing fsl_mc_bus_dpdbg_type declaration

On Wed, Jan 07, 2026 at 08:39:41AM +0100, Christophe Leroy (CS GROUP) wrote:

Hi Ioana,

Le 07/01/2026 à 06:30, Greg Kroah-Hartman a écrit :

quoted

On Tue, Jan 06, 2026 at 07:54:21PM +0100, Christophe Leroy (CS GROUP) wrote:

quoted

Fix following sparse warning:

   CHECK   drivers/bus/fsl-mc/fsl-mc-bus.c
drivers/bus/fsl-mc/fsl-mc-bus.c:435:26: warning: symbol 'fsl_mc_bus_dpdbg_type' was not declared. Should it be static?

As it is exported it can't be static. So declare it in mc.h like
all other similar objects.

Fixes: e70ba1b06c26 ("bus: fsl-mc: add the dpdbg device type")
Signed-off-by: Christophe Leroy (CS GROUP) <chleroy@kernel.org>
---
  include/linux/fsl/mc.h | 1 +
  1 file changed, 1 insertion(+)

diff --git a/include/linux/fsl/mc.h b/include/linux/fsl/mc.h
index 897d6211c1635..28441a456bb48 100644
--- a/include/linux/fsl/mc.h
+++ b/include/linux/fsl/mc.h

@@ -451,6 +451,7 @@ extern const struct device_type fsl_mc_bus_dpdcei_type;
  extern const struct device_type fsl_mc_bus_dpaiop_type;
  extern const struct device_type fsl_mc_bus_dpci_type;
  extern const struct device_type fsl_mc_bus_dpdmai_type;
+extern const struct device_type fsl_mc_bus_dpdbg_type;

As it's obviously not used anywhere, this should not be the fix, please
just mark it static and remove the EXPORT_SYMBOL_GPL() as well.

What's your opinion here as Maintainer of this driver, what should we do ?

Greg is right that it is nowhere used, and it is the same for several other
types, the only difference being that they have a matching
is_fsl_mc_bus_dp..() helper that hides the type, but not all helpers are
used, and many of them are not used outside drivers/bus/fsl-mc/ which cannot
be built as a module:

Anything that does not need to be exported (i.e. not used by anything
else in the kernel tree), should be made static.

thanks,

greg k-h