Thread (4 messages) flat view 4 messages, 2 authors, 2026-01-07

Re: [PATCH] bus: fsl-mc: add missing fsl_mc_bus_dpdbg_type declaration

From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Date: 2026-01-07 05:30:27
Also in: linux-arm-kernel, lkml

On Tue, Jan 06, 2026 at 07:54:21PM +0100, Christophe Leroy (CS GROUP) wrote:
quoted hunk ↗ jump to hunk
Fix following sparse warning:

  CHECK   drivers/bus/fsl-mc/fsl-mc-bus.c
drivers/bus/fsl-mc/fsl-mc-bus.c:435:26: warning: symbol 'fsl_mc_bus_dpdbg_type' was not declared. Should it be static?

As it is exported it can't be static. So declare it in mc.h like
all other similar objects.

Fixes: e70ba1b06c26 ("bus: fsl-mc: add the dpdbg device type")
Signed-off-by: Christophe Leroy (CS GROUP) <chleroy@kernel.org>
---
 include/linux/fsl/mc.h | 1 +
 1 file changed, 1 insertion(+)
diff --git a/include/linux/fsl/mc.h b/include/linux/fsl/mc.h
index 897d6211c1635..28441a456bb48 100644
--- a/include/linux/fsl/mc.h
+++ b/include/linux/fsl/mc.h
@@ -451,6 +451,7 @@ extern const struct device_type fsl_mc_bus_dpdcei_type;
 extern const struct device_type fsl_mc_bus_dpaiop_type;
 extern const struct device_type fsl_mc_bus_dpci_type;
 extern const struct device_type fsl_mc_bus_dpdmai_type;
+extern const struct device_type fsl_mc_bus_dpdbg_type;
As it's obviously not used anywhere, this should not be the fix, please
just mark it static and remove the EXPORT_SYMBOL_GPL() as well.

thanks,

greg k-h
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help