Thread (58 messages) 58 messages, 8 authors, 2025-10-28

Re: [PATCH v3 03/13] powerpc/mm: implement arch_flush_lazy_mmu_mode()

From: David Hildenbrand <hidden>
Date: 2025-10-24 14:42:16
Also in: linux-arm-kernel, linux-mm, lkml, sparclinux, xen-devel

On 24.10.25 14:09, Kevin Brodsky wrote:
On 23/10/2025 21:36, David Hildenbrand wrote:
quoted
On 15.10.25 10:27, Kevin Brodsky wrote:
quoted
[...]
diff --git a/arch/powerpc/include/asm/book3s/64/tlbflush-hash.h
b/arch/powerpc/include/asm/book3s/64/tlbflush-hash.h
index 146287d9580f..7704dbe8e88d 100644
--- a/arch/powerpc/include/asm/book3s/64/tlbflush-hash.h
+++ b/arch/powerpc/include/asm/book3s/64/tlbflush-hash.h
@@ -41,6 +41,16 @@ static inline void arch_enter_lazy_mmu_mode(void)
       batch->active = 1;
   }
   +static inline void arch_flush_lazy_mmu_mode(void)
+{
+    struct ppc64_tlb_batch *batch;
+
+    batch = this_cpu_ptr(&ppc64_tlb_batch);
The downside is the double this_cpu_ptr() now on the
arch_leave_lazy_mmu_mode() path.
This is only temporary, patch 9 removes it from arch_enter(). I don't
think having a redundant this_cpu_ptr() for a few commits is really a
concern?
Oh, right. Consider mentioning in the patch description

"Note that follow-up patches will remove the double this_cpu_ptr() on 
the arch_leave_lazy_mmu_mode() path again."

-- 
Cheers

David / dhildenb

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help