Re: [PATCH 1/2] drivers/base/node: merge register_one_node() and register_node() to a single function.
From: David Hildenbrand <hidden>
Date: 2025-09-25 09:37:22
Also in:
linux-mm, lkml
On 25.09.25 11:34, Mike Rapoport wrote:
On Thu, Sep 25, 2025 at 10:54:07AM +0200, David Hildenbrand wrote:quoted
On 24.09.25 20:40, Donet Tom wrote:quoted
register_one_node() and register_node() are small functions. This patch merges them into a single function named register_node() to improve code readability. No functional changes are introduced. Signed-off-by: Donet Tom <redacted> ---[...]quoted
/** * unregister_node - unregister a node device * @node: node going away@@ -869,7 +842,13 @@ void register_memory_blocks_under_node_hotplug(int nid, unsigned long start_pfn, } #endif /* CONFIG_MEMORY_HOTPLUG */ -int register_one_node(int nid) +/*We can directly convert this to proper kernel doc by using /**quoted
+ * register_node - Setup a sysfs device for a node. + * @nid - Node number to use when creating the device. + * + * Initialize and register the node device.and briefly describing what the return value means "Returns 0 on success, ..."For kernel-doc it should be Return: 0 on success, ...
Yeah; I recall that kerneldoc does not complain when using "Returns ...", but probably it will not be indicated accordingly. -- Cheers David / dhildenb